Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone Gnav changes - Grey bg color, Auto stage link conversion, full width, search container and Jarvis chat through gnav #3058

Closed
wants to merge 11 commits into from
Closed

Standalone Gnav changes - Grey bg color, Auto stage link conversion, full width, search container and Jarvis chat through gnav #3058

wants to merge 11 commits into from

Conversation

bandana147
Copy link
Contributor

@bandana147 bandana147 commented Oct 17, 2024 •
edited
Loading

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Oct 17, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Oct 17, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.34%. Comparing base (ec48f3c) to head (cacf93b).
Report is 2 commits behind head on stage.

Files with missing lines Patch % Lines
libs/navigation/bootstrapper.js 94.11% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #3058      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         243      243              
  Lines       55284    55358      +74     
==========================================
+ Hits        53261    53332      +71     
- Misses       2023     2026       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa spadmasa self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@sonawanesnehal3 sonawanesnehal3 deleted the gnav branch November 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonijain3 salonijain3 salonijain3 approved these changes

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

Assignees

@spadmasa spadmasa

@prativas22 prativas22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bandana147 @salonijain3 @spadmasa @prativas22 @Deva309